Re: 2.3.99-3/3 IDE link problems (+msdos partitions)

From: Andre Hedrick (andre@suse.com)
Date: Mon Mar 20 2000 - 14:38:49 EST

  • Next message: Marco Colombo: "Re: Avoiding OOM on overcommit...?"

    Okay one down, many to go.......

    On Mon, 20 Mar 2000, Geert Uytterhoeven wrote:

    > On Mon, 20 Mar 2000, Andre Hedrick wrote:
    > > add to "fs/partitions/msdos.c"
    > >
    > > #ifdef CONFIG_IDE
    > > #include <linux/ide.h>
    > > #endif /* CONFIG_IDE */
    >
    > Note that there's already `#include <linux/ide.h> /* IDE xlate */' at the top.
    > I replaced it with the conditional include you mentioned above.
    >
    > > replace all
    > >
    > > #if defined(CONFIG_BLK_DEV_IDE) || defined(CONFIG_BLK_DEV_IDE_MODULE)
    > > #endif /* (CONFIG_BLK_DEV_IDE) || (CONFIG_BLK_DEV_IDE_MODULE) */
    > >
    > > with
    > >
    > >
    > > #ifdef CONFIG_IDE
    > > #endif /* CONFIG_IDE */
    > >
    > > Then tell me what happens, this fixed the issue but I have not submitted
    > > it yet......nailing other boogers!!!!!!!
    >
    > Well, this fixes the link problem.
    >
    > But that's only part of the problem: now the modular IDE driver can no longer
    > handle disks that need the ide_xlate_1024() trick.
    >
    > > On Mon, 20 Mar 2000, Geert Uytterhoeven wrote:
    > > > On Mon, 20 Mar 2000, Geert Uytterhoeven wrote:
    > > > > ide-geometry.o (always compiled in the kernel) needs current_capacity() and
    > > > > get_info_ptr(), which are defined in ide.c.
    > > > >
    > > > > However, if CONFIG_BLK_DEV_IDE=m and CONFIG_IDE=y, ide.o is compiled as a
    > > > > module causing a kernel link failure.
    > > >
    > > > Retrying with CONFIG_BLK_DEV_IDE=m and CONFIG_IDE=m showed an even worse
    > > > problem: fs/partitions/msdos.c needs ide_xlate_1024(), which is defined in
    > > > ide-geometry.o, but the latter file is compiled as a module if CONFIG_IDE=m.
    > > >
    > > > Time to drop IDE from the .config completely...
    >
    > Gr{oetje,eeting}s,
    >
    > Geert
    >
    > --
    > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
    >
    > In personal conversations with technical people, I call myself a hacker. But
    > when I'm talking to journalists I just say "programmer" or something like that.
    > -- Linus Torvalds
    >

    Andre Hedrick
    The Linux ATA/IDE guy

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Mon Mar 20 2000 - 17:11:20 EST