Re: Hundreds of bugs in 2.3.99-pre3

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Sat Apr 01 2000 - 05:04:13 EST

  • Next message: Christoph Hellwig: "Re: block_dev.c not backward compatible with 2.2.15 APIs"

    From: "Mitchell Blank Jr" <mitch@sfgoth.com>
    > The places that look up entries in these "register"ed lists do so with
    > the big-kernel-lock, which also protects against module_{init,exit}.
    > I think the socket-type lookup didn't follow this at one point... not
    > sure if that got fixed.
    Yes, but what if module_exit() sleeps _before_ it unlinks itself from these
    lists?

    Tim checked all foo_open() functions, AFAICS we must also check all unload
    functions :-(

    > The only problem is if module_init does something that sleeps (for
    instance
    > allocs non-atomic memory) before incrementing the module count, since the
    > sleep will give up the big-lock, and another thread can then rmmod
    > the driver (since it has a zero module count).

    No, this cannot happen: sys_init_module() increases the module count before
    calling module_init().

    --
        Manfred
    

    - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Sat Apr 01 2000 - 05:27:08 EST