joystick bug (was Re: [PATCH] f_op->poll() without lock_kernel())

From: Manfred Spraul (manfreds@colorfullife.com)
Date: Fri Apr 21 2000 - 17:16:10 EDT

Next message: Greg Baker: "Re: VM: killing... (and Oops!)"

Previous message: Linda Walsh: "return values - 32, 64, 128 bits, type defs...etc/platform size"
In reply to: David S. Miller: "Re: [PATCH] f_op->poll() without lock_kernel()"
Next in thread: Linus Torvalds: "Re: [PATCH] f_op->poll() without lock_kernel()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Vojtech,

Do you still maintain the joystick driver?

I noticed that js_read() calls copy_to_user() with a spinlock acquired.
This could cause dead-locks on SMP, could you store the result in a
temporary buffer, and call copy_to_user() after you released the
spinlock?

And js_read()/js_poll are never called with disabled interrupts, you
could use spin_lock_irq() instead of spin_lock_irqsave().

-- manfred

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/

Next message: Greg Baker: "Re: VM: killing... (and Oops!)"
Previous message: Linda Walsh: "return values - 32, 64, 128 bits, type defs...etc/platform size"
In reply to: David S. Miller: "Re: [PATCH] f_op->poll() without lock_kernel()"
Next in thread: Linus Torvalds: "Re: [PATCH] f_op->poll() without lock_kernel()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Apr 21 2000 - 17:16:54 EDT