I have USB almost ready if Linus wants this patch.
I'll send it anyway since only 2 of about 25 files need
to be patched and it will make their struct inits all the same
and facilitate grepping.
~Randy
___________________________________________________
> -----Original Message-----
> From: Alexander Viro [mailto:viro@math.psu.edu]
> Sent: Friday, April 21, 2000 3:13 PM
> To: David S. Miller
> Cc: manfreds@colorfullife.com; alan@lxorguk.ukuu.org.uk;
> torvalds@transmeta.com; linux-kernel@vger.rutgers.edu;
> linux-fsdevel@vger.rutgers.edu; kumon@flab.fujitsu.co.jp
> Subject: Re: [PATCH] f_op->poll() without lock_kernel()
>
> On Fri, 21 Apr 2000, David S. Miller wrote:
>
> > Date: Fri, 21 Apr 2000 23:49:45 +0200
> > From: Manfred Spraul <manfreds@colorfullife.com>
> >
> > How did you grep? You missed
> >
> > drivers/char/qpmouse.c:
> > poll_pq() looks good, but read_qp() needs lock_kernel.
> > [while(!queue_empty()) { get_from_queue()} ]
> >
> > I used "*_poll", and filtered out the noise by hand.
> >
> > I think poll_pq should be renamed to pq_poll, so that it
> uses a naming
> > convention in sync with what everyone else does.
>
> What _should_ be done is the conversion of initializers to new syntax.
> BTW, IWBNI the same would be done for proto/proto_ops. Dave, would you
> accept the net/*/* side of such patch? I can send it in an hour or so.
> Block devices, fs_struct, super_operations, file_operations in
> filesystems, dentry_operations and inode_operations are already there.
> Linus, will you accept the patch for character devices? Let's
> finish the
> stinker and make sure that _all_ methods tables are initialized
> a) statically
> b) via the field: value; syntax.
> Will make for much simpler searches...
> Al
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Apr 21 2000 - 18:39:48 EDT