[patch-2.3.99-pre6-5] drivers/block/floppy.c cleanup

From: Tigran Aivazian (tigran@veritas.com)
Date: Sat Apr 22 2000 - 13:38:18 EDT

  • Next message: kuznet@ms2.inr.ac.ru: "Re: [PATCH] f_op->poll() without lock_kernel()"

    Hi Linus,

    1. register_devfs_entries() and config_types() are used only at
    initialization so they can be __init'd.

    2. the message "Read linux/drivers/block/README.fd\n" should refer
       to linux/Documentation/floppy.txt instead.

    Regards,
    Tigran

    --- floppy.c.0 Sat Apr 22 18:32:16 2000
    +++ floppy.c Sat Apr 22 18:33:30 2000
    @@ -201,7 +201,7 @@
     static unsigned short virtual_dma_port=0x3f0;
     void floppy_interrupt(int irq, void *dev_id, struct pt_regs * regs);
     static int set_dor(int fdc, char mask, char data);
    -static void register_devfs_entries (int drive);
    +static void register_devfs_entries (int drive) __init;
     static devfs_handle_t devfs_handle = NULL;
     
     #define K_64 0x10000 /* 64KB */
    @@ -3582,7 +3582,7 @@
     #undef IN
     }
     
    -static void config_types(void)
    +static void __init config_types(void)
     {
             int first=1;
             int drive;
    @@ -3836,7 +3836,7 @@
             revalidate: floppy_revalidate,
     };
     
    -static void register_devfs_entries (int drive)
    +static void __init register_devfs_entries (int drive)
     {
         int base_minor, i;
         static char *table[] =
    @@ -4075,7 +4075,7 @@
                     printk("\n");
             } else
                     DPRINT("botched floppy option\n");
    - DPRINT("Read linux/drivers/block/README.fd\n");
    + DPRINT("Read linux/Documentation/floppy.txt\n");
             return 0;
     }
     

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Sat Apr 22 2000 - 13:59:55 EDT