Re: [patch-2.3.99-pre6-5] drivers/block/floppy.c cleanup

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat Apr 22 2000 - 14:02:36 EDT

  • Next message: Matthew Hanselman: "Oops in paging request with 2.2.14"

    Tigran Aivazian wrote:
    > --- floppy.c.0 Sat Apr 22 18:32:16 2000
    > +++ floppy.c Sat Apr 22 18:33:30 2000
    > @@ -201,7 +201,7 @@
    > static unsigned short virtual_dma_port=0x3f0;
    > void floppy_interrupt(int irq, void *dev_id, struct pt_regs * regs);
    > static int set_dor(int fdc, char mask, char data);
    > -static void register_devfs_entries (int drive);
    > +static void register_devfs_entries (int drive) __init;
    > static devfs_handle_t devfs_handle = NULL;
    >
    > #define K_64 0x10000 /* 64KB */

    What are people's opinions on this?

    Marking prototypes as __init is ugly and unnecessary IMNSHO, but making
    a function's __init status obvious to code readers might be considered a
    good thing.

            Jeff 

    -- 
Jeff Garzik              | Nothing cures insomnia like the
Building 1024            | realization that it's time to get up.
MandrakeSoft, Inc.       |        -- random fortune

    -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Sat Apr 22 2000 - 14:22:50 EDT