Hello!
> this is updated PCI quirk for ACPI devices.
> Changes from previous post:
> - fixup type changed PCI_FIXUP_FINAL -> PCI_FIXUP_HEADER;
> - added IRQ setting for Intel and VIA devices;
I'm not sure at all how does ACPI IRQ routing work on machines other than
PC's or even on SMP PC's. Doing things like `dev->irq = 9' in platform independent
code smells of problems.
You should either decide ACPI is not used outside the PC world and move the
quirks to arch/i386/pci-pc.c or do the IRQ fixups in the ACPI driver which is
i386 specific as well.
> Also one question:
> why dev->irq != dev->irq_resource[0].start in pci_dev structure ?
> IMHO it cause some ugly lines of code in drivers supporting both PCI
> and ISA PnP devices (look at /linux/drivers/char/serial.c for example).
It's basically because I wanted to avoid keeping track of two IRQ number
variables in the core code and the simplification of such combo drivers is
too small to outweigh the core changes.
Have a nice fortnight
-- Martin `MJ' Mares <mj@ucw.cz> <mj@suse.cz> http://atrey.karlin.mff.cuni.cz/~mj/ "A bug in the code is worth two in the documentation."- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat May 13 2000 - 08:46:28 EDT