Re: Proposal: int (permission*)(struct dentry *, int)

• Previous message: Matt Yourst: "Re: bugreport: pre7 NFS mmap locked in disk wait (in pre8 too)"
• In reply to: Trond Myklebust: "Proposal: int (permission*)(struct dentry *, int)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

       changes to the VFS API:
         - fs/namei.c:permission() is changed to take a dentry argument
            instead of an inode.
    and
         - ditto for the permission callback in the inode_operations

Since from a dentry wee can always get an inode but not the converse
I think this is a good change (the additional cost of a few cycles in
a couple of places is negligible).

[...]

    - if (rep || dentry->d_count > 1 || permission(inode, MAY_WRITE) || get_write_access(inode)) goto ret;
    + if (rep || dentry->d_count > 1 || vfs_permission(inode, MAY_WRITE) || get_write_access(inode)) goto ret;

Off on a tangent -- I wish people would bracket things to emphasize
the order of operations, something like:

        if(rep || (dentry->d_count>1) || vfs_permission(inode,MAY_WRITE) || get_write_access(inode)) goto ret;

it more readable IMO.

  --cw

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Chester Bochan: "IP masq'ing bug on a sparc IPX w/ 1 net card"
• Previous message: Matt Yourst: "Re: bugreport: pre7 NFS mmap locked in disk wait (in pre8 too)"
• In reply to: Trond Myklebust: "Proposal: int (permission*)(struct dentry *, int)"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat May 13 2000 - 22:49:39 EDT