Re: [PATCH] small rtc.c fix

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Fri May 19 2000 - 16:34:37 EDT

  • Next message: beej-a: "pre-compile time error"

    Cesar Eduardo Barros wrote:
    >
    > This patch fixes a simple thinko in my last rtc patch which could in completely
    > unlikely situations printk a wrong frequency value in rtc_dropped_irq (harmless
    > but wrong anyway).
    >
    > I'm still a bit wary about putting printk inside a spinlock critical region.
    > Comments?

    If you don't want the printk inside a spinlock, you can always grab the
    spinlock, store to a temporary, release the spinlock, and then do the
    printk.

    Also, make sure you increase the RTC when you do fixes as well as
    feature updates...

            Jeff 

    -- 
Jeff Garzik              | Liberty is always dangerous, but
Building 1024            | it is the safest thing we have.
MandrakeSoft, Inc.       |      -- Harry Emerson Fosdick

    -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Fri May 19 2000 - 16:38:52 EDT