In message <20000519225041.P28590@thepuffingroup.com>, willy@thepuffingroup.com writes:
> On Fri, May 19, 2000 at 10:30:52PM -0400, willy@thepuffingroup.com wrote:
> [and forgot to include the patch URL]
>
> ftp://ftp.uk.linux.org/pub/linux/people/willy/
>
> lock-2.3.99pre8.diff is the kernel patch and dirnot.c is an example program
> using the interface.
I looked briefly at the patch, and I'm afraid I don't understand some basic
things. Perhaps you can let us (-fsdevel) all know the following (which you
should probably put in a README on your Web page along w/ the patches):
- what is directory notification
- (is it related at all to notify_change or the old check_media_change?)
- what is it good for
- why it cannot be done using other mechanisms
- an overview of how it can be used (I couldn't understand it from your test
program)
- an overview of what your patch does. (Your patch seems rather long. You
should explain on this list why it is that long, what it does, etc.)
- what impact, if any, does your patch have on the rest of the kernel and
other file systems.
Whenever I write and submit patches, I accompany them with a README that
gives people (and esp. kernel maintainers) an overview of what the patch
does. The kernel maintainers are very busy and get many patch submissions
all the time; my feeling is that a well thought and well documented patch
stands a much better chance of getting accepted.
Thanks,
Erez. (stacking guy :-)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat May 20 2000 - 15:35:31 EDT