[PATCH] Re: Old HD driver does not compile in 2.3.99pre9-2

From: Andries Brouwer (aeb@veritas.com)
Date: Sat May 20 2000 - 19:47:30 EDT

  • Next message: Andre Hedrick: "Re: [PATCH] Re: Old HD driver does not compile in 2.3.99pre9-2"

    On Fri, May 19, 2000 at 05:01:03PM +0200, Andrzej Krzysztofowicz wrote:

    > I noticed that when setting CONFIG_BLK_DEV_HD=y 2.3.99pre9-2 kernel
    > (and probably some earliers) does not compile:

    Yes - if I am not mistaken Andre has already corrected that.

    > During start:
    >
    > hda: 0MB, CHS=1108/255/63
    > ^^^^^
    > Partition check:
    > hda: hda1 hda2 hda3
    > ...
    >
    > and kernel cannot mount root fs on hda3.

    Yes. That is a bug introduced in 2.3.40 by Al Viro's
    "grok_partitions" patch, if I am not mistaken.

    Patch (on 2.3.99p8):
    ----------------------------------------------------------------
    --- hd.c~ Sun Mar 26 13:06:39 2000
    +++ hd.c Sun May 21 01:19:35 2000
    @@ -778,6 +778,8 @@
     #endif
     
             for (drive=0 ; drive < NR_HD ; drive++) {
    + hd[drive<<6].nr_sects = hd_info[drive].head *
    + hd_info[drive].sect * hd_info[drive].cyl;
                     printk ("hd%c: %ldMB, CHS=%d/%d/%d\n", drive+'a',
                             hd[drive<<6].nr_sects / 2048, hd_info[drive].cyl,
                             hd_info[drive].head, hd_info[drive].sect);
    ----------------------------------------------------------------

    > Any suggestions how should it be fixed ?

    See above. Please complain if this doesnt fix it.

    > Or is the "old disk-only driver" hd.c obsolete and to be dropped ?

    The fact that you are the first to complain is an indication
    that not many kernel developers use this old hd.c.
    But it should remain functional.

    Andries

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Sat May 20 2000 - 20:04:19 EDT