On Fri, 2 Jun 2000, Andre Hedrick wrote:
> On Fri, 2 Jun 2000, Bartlomiej Zolnierkiewicz wrote:
>
> >
> > This "simple & stupid" patch:
> > - adds recognition of newest VIA chipset (Apollo PM133)
>
> (VERY BAD)
> You did not follow the model........
> 1:1 table entry regardless of dupilcation (for now)
Andre please explain... I don't understand what is bad....
>
> > - fixes recognition of AMD Irongate
>
> It worked jsut fine??
There was:
host = pci_find_device (PCI_VENDOR_ID_VIA,
ApolloHostChipInfo[i].host_id,
NULL);
So Irongate wasn't even found. It was intentionally? If so where's the
comment?
It should work. I don't have Irongate. That's why I posted patch on lkml.
>
> > - adds & fixes some VIA's pci ids
>
> DGD.........
>
> > - removes duplicate via82cxxx_table
>
> (VERY BAD)
> No table three is there because there are differnet modes.
These tables (two & three) were _identical_.
> Three and Four are paired based on the detection pdiag-pclid
Yep. My patch doesn't change this behaviour...
>
> There will be additions to these tables and they will vary.....NDA!
>
I supposed this, but there was no comment.
It is the right way to have unnecessary data in kernel for weeks?
Shouldn't you add this table when they vary?
Regards
-- Bartlomiej Zolnierkiewicz <bkz>- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jun 03 2000 - 06:13:57 EDT