Thanks, but I subsequently submitted a patch very much like
yours, except that it only changed the second of the two lines that
you changed (in exactly the same way). There is no need to change
the part that does not do the long division, and my approach would have
the advantage that if the count were to exceed 2**32 cycles, at least
the total number of cycles would be correctly printed. However, come
to think of it, the format string then needs to changed. So,
here is a corrected patch. I have rebuilt the arcnet drivers with
this patch and verified that they build and there are no undefined
symbols in the kernel modules.
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
--- linux-2.4.0-test3/include/linux/arcdevice.h Thu Jun 29 11:11:22 2000
+++ linux/include/linux/arcdevice.h Tue Jul 11 03:47:44 2000
@@ -100,10 +100,10 @@
call; \
_y = get_cycles(); \
BUGMSG(D_TIMING, \
- "%s: %d bytes in %lu cycles == " \
+ "%s: %d bytes in %Lu cycles == " \
"%lu Kbytes/100Mcycle\n",\
name, bytes, _y - _x, \
- 100000000 / 1024 * bytes / (_y - _x + 1));\
+ 100000000 / 1024 * bytes / (unsigned long) (_y - _x + 1));\
} \
else { \
call;\
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Tue Jul 11 2000 - 06:58:16 EDT