Re: 2.4.0-test5-pre4 compile warning fixes

• Previous message: Ville Herva: "Re: Strange semi-hang with 2.2.16pre5 SMP"
• In reply to: Frank van Maarseveen: "2.4.0-test5-pre4 compile warning fixes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 25 Jul 2000, Frank van Maarseveen wrote:

> if (offset % ssize) {
> - printk(KERN_WARNING "jffs_flash_erasable_size() given non-aligned offset %lx (erasesize %lx)\n", offset, ssize);
> + printk(KERN_WARNING "jffs_flash_erasable_size() given non-aligned offset %lx (erasesize %lx)\n", (u_long)offset, ssize);

Actually, I'd much rather just see

        %x, offset

because "u32" is a "int" or possibly in the future a "short". Linux
doesn't support any sub-32-bit computers, and despite the occasional
deranged people interested in retro-computing (ie Alan Cox) I doubt it
seriously will..

I dislike casts.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Matthew Wilcox: "Re: Performance problems with Linux file serving. in recent 2.4 kernels"
• Previous message: Ville Herva: "Re: Strange semi-hang with 2.2.16pre5 SMP"
• In reply to: Frank van Maarseveen: "2.4.0-test5-pre4 compile warning fixes"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Jul 25 2000 - 17:40:50 EDT