On Thu, 27 Jul 2000, Andries Brouwer wrote:
[I wrote:]
> > Deal? BTW, while we are at it, could you add -bind (MNT_BIND)
> > option (can be combined with any of these)? -t bind syntax is a kludge and
> > I would be glad to get rid of it.
>
> Deal.
>
> Consider calling the constants MS_xxx for consistency with other
> constants. Consider putting them in <linux/mount_constants.h>
> since <linux/fs.h> contains such a lot of crap already.
Why not linux/mount.h?
> Tell me the final names and values.
> (I expect to come with util-linux-2.10n soon.)
How about
MS_ACTION_MASK 0x380
MS_REPLACE 0x080
MS_AFTER 0x100
MS_BEFORE 0x180
MS_OVER 0x200
MS_BIND 4096
(notice that it these bits are _not_ going into ->s_flags or ->i_flags, so
there is no conflict with the current S_APPEND and friends). Actually, I'm
sorely tempted to redefine MS_REMOUNT as 0x280 and get a consistent
picture, but that would probably be wrong. Reason for that bitmask trick:
we are out of bits.
I'm not promising the moment when it will get into the tree, indeed - I'll
submit a patch today, but when it will be applied... ask Linus.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Thu Jul 27 2000 - 16:05:33 EDT