Re: [PATCH] drivers/char/pcwd.c: kmalloc fixes

From: Arnaldo Carvalho de Melo (acme@conectiva.com.br)
Date: Mon Aug 14 2000 - 13:51:14 EDT

  • Next message: Oliver Neukum: "Re: Definitions"

    Em Mon, Aug 14, 2000 at 12:17:44PM -0500, Bill Wendling escreveu:
    > Also sprach Arnaldo Carvalho de Melo:
    > }
    > } Hi,
    > }
    > } Please take a look and consider applying.
    > }
    > } - Arnaldo
    > }
    > } @@ -503,9 +505,7 @@
    > } static inline char *get_firmware(void)
    > } {
    > } int i, found = 0, count = 0, one, ten, hund, minor;
    > } - char *ret;
    > } -
    > } - ret = kmalloc(6, GFP_KERNEL);
    > } + static char ret[6];
    > }
    > } while((count < 3) && (!found)) {
    > } outb_p(0x80, current_readport + 2);
    > }
    > Does this make the function non-parallel (threadable)?

    possibly, does it need to be? Humm, more than one watchdog board,
    just to be sure 8) ok, I'll take a look.

    - Arnaldo

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.rutgers.edu
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Mon Aug 14 2000 - 13:46:08 EDT