Re: [PATCH] Fix disk statistic reporting to include all disks

• Previous message: David Lang: "Re: Raid 1/upgrade to 2.2.16"
• In reply to: Bill Wilson: "[PATCH] Fix disk statistic reporting to include all disks"
• Next in thread: Jens Axboe: "Re: [PATCH] Fix disk statistic reporting to include all disks"
• Reply: Jens Axboe: "Re: [PATCH] Fix disk statistic reporting to include all disks"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Tue, 29 Aug 2000, Bill Wilson wrote:
>
> This patch fixes the enhanced disk statistics to report all drives
> so IDE1 - IDE3 (/dev/hdc - /dev/hdh) can be monitored.

Why not just do this right, and move the statistics into the "queue
structure". Get rid of that ugly kstat thing. Get rid of all the special
case lookups. We already need to have the queue structure to do the
queuing (surprise, surprise), so suddenly statistics are (a) cheap and (b)
right.

So then /proc just needs to be changed to look at the queues instead of
looking at this kstat thing.

                Linus

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Alan Cox: "Re: Raid 1/upgrade to 2.2.16"
• Previous message: David Lang: "Re: Raid 1/upgrade to 2.2.16"
• In reply to: Bill Wilson: "[PATCH] Fix disk statistic reporting to include all disks"
• Next in thread: Jens Axboe: "Re: [PATCH] Fix disk statistic reporting to include all disks"
• Reply: Jens Axboe: "Re: [PATCH] Fix disk statistic reporting to include all disks"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Tue Aug 29 2000 - 17:26:51 EDT