Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups

From: Philipp Rumpf (prumpf@parcelfarce.linux.theplanet.co.uk)
Date: Tue Aug 29 2000 - 17:31:22 EDT

  • Next message: Albert D. Cahalan: "Re: [patch] scheduler bugfix, SMP, 2.4.0-test7"

    On Sun, Aug 27, 2000 at 10:28:14PM +0200, Kenneth Johansson wrote:
    > Arnaldo Carvalho de Melo wrote:
    >
    > > #include <linux/config.h>
    > > @@ -510,10 +511,7 @@
    > > if (put_user(len, optlen))
    > > return -EFAULT;
    > >
    > > - if (copy_to_user(optval, &val, len))
    > > - return -EFAULT;
    > > -
    > > - return 0;
    > > + return copy_to_user(optval, &val, len) ? -EFAULT : 0;
    > > }
    >
    > What is this are you trying to compress the source code ?
    > I like the old way better. I think it is faster to read and understand.

    Same here. Linus, I didn't actually interpret your mail on the subject as
    proposing changes like the one above. Care to enlighten this a bit ?

            Philipp Rumpf
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Tue Aug 29 2000 - 17:32:45 EDT