Re: [PATCH] af_rose.c: s/suser/capable/ + micro cleanups

From: Philipp Rumpf (prumpf@parcelfarce.linux.theplanet.co.uk)
Date: Wed Aug 30 2000 - 15:02:06 EDT

  • Next message: Alexander Viro: "Re: hfs support for blocksize != 512"

    On Wed, Aug 30, 2000 at 10:04:12AM -0700, Linus Torvalds wrote:
    > return copy_to_user(dst, src, size) ? -EFAULT : 0;
    >
    > is fine and quite readable. Fits on a simple line.

    I agree so far. But when it's really

            if (put_user(..>)
                    return -EFAULT;
            
            if (put_user(...))
                    return -EFAULT;
            
            if (copy_to_user(...))
                    return -EFAULT;
            
            if (copy_to_user(...))
                    return -EFAULT;

            return 0;

    changing the last two statements to use ? : is just confusing (acme's changes
    were somewhat less extreme), don't you agree ?

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Wed Aug 30 2000 - 15:06:04 EDT