Re: [PATCH] mtrr: s/suser/capable/

From: Andi Kleen (ak@suse.de)
Date: Thu Aug 31 2000 - 07:15:02 EDT

  • Next message: Alan Cox: "Re: [PATCH] mtrr: s/suser/capable/"

    On Thu, Aug 31, 2000 at 11:27:17AM +0100, Matthew Kirkwood wrote:
    > > - if ( !suser () ) return -EPERM;
    > > + if ( !capable(CAP_SYS_ADMIN) ) return -EPERM;
    >
    > Please think further about these random changes. CAP_SYS_ADMIN
    > is already bloated with useless junk and these aren't helping
    > the situation.
    >
    > These cases in mtrr.c are clearly CAP_SYS_RAWIO.

    Clearly? How do MTRR changes relate to rawio ?

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Thu Aug 31 2000 - 07:16:21 EDT