Re: [PATCH] alignment issue with ipchains

From: Andi Kleen (ak@suse.de)
Date: Sat Sep 09 2000 - 10:22:10 EDT

  • Next message: Richard Gooch: "Re: Notebook disk spindown"

    On Sat, Sep 09, 2000 at 03:03:27PM +0900, NIIBE Yutaka wrote:
    > - }
    > + if (optname == IP_PKTINFO || optname == IP_RECVTTL
    > + || optname == IP_RECVTOS || optname == IP_RECVOPTS
    > + || optname == IP_RETOPTS || optname == IP_TOS
    > + || optname == IP_TTL || optname == IP_HDRINCL
    > + || optname == IP_MTU_DISCOVER || optname == IP_RECVERR
    > + || optname == IP_MULTICAST_TTL || optname == IP_MULTICAST_LOOP
    > + || optname == IP_ROUTER_ALERT)

    This is ugly. I guess using a small table would be smaller and cleaner,
    or alternatively just use a copy_from_user [would be the best solution
    imho]

    -Andi
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Sat Sep 09 2000 - 10:23:54 EDT