Re: [PATCH] abuse of macros in swab.h

From: Alexander Viro (viro@math.psu.edu)
Date: Tue Sep 19 2000 - 20:01:35 EDT

  • Next message: Jens Axboe: "Re: (reiserfs) Re: An elevator algorithm (patch)"

    On Tue, 19 Sep 2000, Linus Torvalds wrote:

    >
    >
    > On Tue, 19 Sep 2000, David S. Miller wrote:
    > >
    > > Would you mind taking a look at the difference in code output when
    > > register pressure in a given function is moderate to high? :-)
    >
    > Immaterial.
    >
    > If somebody cares about performance, they'd just better create the proper
    > architecture-specific macros.
    >
    > Correctness first.

            Well, Andi's variant with statement expression looks like a decent
    compromise - it's gccism, indeed, but IIRC it was on the list of approved
    extensions. I would go with it.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Tue Sep 19 2000 - 20:02:22 EDT