Re: tty_[un]register_devfs putting 3K structures on the stack

• Previous message: Rik van Riel: "Re: 2.4.0-test9-pre8"
• In reply to: Theodore Y. Ts'o: "Re: tty_[un]register_devfs putting 3K structures on the stack"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

tytso@MIT.EDU said:
> And it's allocating a tty_struct for a really dumb reason, too. It's
> just using it so it cna call tty_name.

> Just replace the call to tty_name with something like this:

> sprintf(buf, driver->name, idx + driver->name_base)

> and make the obvious change to avoid using tty.device, and you can
> avoid need to allocate a tty_struct altogether.

Are you willing to consider this a critical bug that deserves to be fixed
before 2.4.0?

If so, I'm willing to make the fix and send it to whoever wants it.

                                Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Byron Stanoszek: "Re: [PATCH] VM fix for 2.4.0-test9 & OOM handler"
• Previous message: Rik van Riel: "Re: 2.4.0-test9-pre8"
• In reply to: Theodore Y. Ts'o: "Re: tty_[un]register_devfs putting 3K structures on the stack"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Fri Oct 06 2000 - 16:18:50 EDT