Re: 2.2.17: CPU features bug for AMD?

From: davej@suse.de
Date: Mon Oct 09 2000 - 15:21:30 EDT

  • Next message: David Ford: "Re: [PATCH] VM fix for 2.4.0-test9 & OOM handler"

    Ulrich.Windl@rz.uni-regensburg.de wrote..

    > linux/arch/i386/kernel/setup.c:
    > Isn't here an "else" or "break" missing? Otherwise
    > ``x86_cap_flags[16] = "pat"'' is always the case

    Good spotting!
    There should be an else there, as there is in 2.4

    Regards,

    Dave.

    --- setup.c~ Mon Oct 9 20:18:59 2000
    +++ setup.c Mon Oct 9 20:19:15 2000
    @@ -1192,7 +1192,8 @@
                                     x86_cap_flags[10] = "sep";
                             if (c->x86 < 6)
                                     x86_cap_flags[16] = "fcmov";
    - x86_cap_flags[16] = "pat";
    + else
    + x86_cap_flags[16] = "pat";
                             x86_cap_flags[22] = "mmxext";
                             x86_cap_flags[24] = "fxsr";
                             x86_cap_flags[30] = "3dnowext"; 

    -- 
| Dave Jones <davej@suse.de>  http://www.suse.de/~davej
| SuSE Labs

    -
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Mon Oct 09 2000 - 15:28:05 EDT