Re: [ANNOUNCE] Kernel Janitor's TODO list

From: Roman Zippel (zippel@fh-brandenburg.de)
Date: Mon Jan 29 2001 - 14:47:50 EST

  • Next message: Stefani Seibold: "Re: patch for 2.4.0 disable printk"

    Hi,

    On Mon, 29 Jan 2001, Andi Kleen wrote:

    > You can miss wakeups. The standard pattern is:
    >
    > get locks
    >
    > add_wait_queue(&waitqueue, &wait);
    > for (;;) {
    > if (condition you're waiting for is true)
    > break;
    > unlock any non sleeping locks you need for condition
    > __set_task_state(current, TASK_UNINTERRUPTIBLE);
    > schedule();
    > __set_task_state(current, TASK_RUNNING);
    > reaquire locks
    > }
    > remove_wait_queue(&waitqueue, &wait);

    You still miss wakeups. :)
    Always set the task state first, then check the condition. See the
    wait_event*() macros you mentioned for the right order.

    bye, Roman

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Mon Jan 29 2001 - 15:04:18 EST