Re: SO_SNDTIMEO: 2.4 kernel bugs

From: kuznet@ms2.inr.ac.ru
Date: Sat Feb 17 2001 - 15:29:14 EST

  • Next message: Alan Cox: "Re: 2.4.1ac17 hang on mounting loopback fs"

    Hello!

    > Unfortunately, it seems to be very buggy. Here are two buggy scenarios.

    --- ../vger3-010210/linux/net/ipv4/tcp.c Sat Feb 10 23:16:51 2001
    +++ linux/net/ipv4/tcp.c Sat Feb 17 23:27:43 2001
    @@ -691,6 +691,8 @@
     
                     set_current_state(TASK_INTERRUPTIBLE);
     
    + if (!timeo)
    + break;
                     if (signal_pending(current))
                             break;
                     if (tcp_memory_free(sk) && !vm_wait)
    --- ../vger3-010210/linux/net/core/sock.c Tue Jan 30 21:20:16 2001
    +++ linux/net/core/sock.c Sat Feb 17 23:27:44 2001
    @@ -727,6 +727,8 @@
             clear_bit(SOCK_ASYNC_NOSPACE, &sk->socket->flags);
             add_wait_queue(sk->sleep, &wait);
             for (;;) {
    + if (!timeo)
    + break;
                     if (signal_pending(current))
                             break;
                     set_bit(SOCK_NOSPACE, &sk->socket->flags);
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Sat Feb 17 2001 - 15:30:58 EST