Re: 2.4.2-ac calls FS truncate w/o BKL

From: Alexander Viro (viro@math.psu.edu)
Date: Fri Mar 09 2001 - 12:28:18 EST

  • Next message: Jauder Ho: "Re: Questions about Enterprise Storage with Linux"

    On Fri, 9 Mar 2001, Chris Mason wrote:

    >
    > The added vmtruncate calls in the ac series trigger calls to the FS
    > truncate without the BKL held. Easy enough to fix on the reiserfs side,
    > but if other filesystems care we might want to change vmtruncate to grab
    > the lock before calling truncate (and update the Locking doc ;-)

    Grr... Thanks for spotting - it's my fault. No, I don't think that
    we should move BKL into filesystems right now. Should move it into
    vmtruncate(), though...

    Alan, could you put lock_kernel()/unlock_kernel() around the call of
    ->truncate() in vmtruncate()?
                                                            Thanks,
                                                                    Al

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/



    This archive was generated by hypermail 2b29 : Fri Mar 09 2001 - 12:31:21 EST