Re: Multi-function PCI devices

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat Apr 07 2001 - 15:31:14 EDT

  • Next message: Tim Waugh: "Re: PATCH for Broken PCI Multi-IO in 2.4.3 (serial+parport)"

    Tim Waugh wrote:
    >
    > On Sat, Apr 07, 2001 at 01:23:27PM -0400, Jeff Garzik wrote:
    >
    > > You asked in your last message to show you code, here is a short
    > > example. Note that I would love to rip out the SUPERIO code in parport
    > > and make it a separate driver like this short, contrived example. Much
    > > more modular than the existing solution.
    >
    > (The superio code is on its way out anyway, for different reasons..)

    I think there will be further discussion on this :)

    > More modular? Yes, it adds another module to support a card, so yes
    > there are more modules.
    >
    > But with the multifunction_quirks approach, support is a question of
    > adding two lines in a table.

    struct pci_driver is going to become struct driver, don't forget. With
    that in mind, the "multifunction_quirks" patch appears even more of a
    bus-specific hack.

    Why do you want to dirty the soon-to-be generic driver API for stupid
    hardware?

    It takes two seconds to write a shim driver as I have described, and
    further a shim driver is not necessary on sensible hardware.

            Jeff 

    -- 
Jeff Garzik       | Sam: "Mind if I drive?"
Building 1024     | Max: "Not if you don't mind me clawing at the dash
MandrakeSoft      |       and shrieking like a cheerleader."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Sat Apr 07 2001 - 15:34:06 EDT