Re: unsigned long ioremap()?

From: Abramo Bagnara (abramo@alsa-project.org)
Date: Thu May 03 2001 - 04:53:08 EDT

Next message: Alexander Viro: "Re: Why recovering from broken configs is too hard"

Previous message: Pavel Machek: "Trivial cleanup in arch/i386/ptrace.c"
In reply to: Jeff Garzik: "Re: unsigned long ioremap()?"
Next in thread: David Woodhouse: "Re: unsigned long ioremap()?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Jeff Garzik wrote:
>
> Abramo Bagnara wrote:
> > > > That's indeed the reason to change ioremap prototype for 2.5.
> > >
> > > Say what??
> > >
> >
> > Please give a look
> > http://www.uwsg.indiana.edu/hypermail/linux/kernel/0008.1/0338.html
> > http://www.uwsg.indiana.edu/hypermail/linux/kernel/0008.1/0407.html
> >
> > This was something that already got a wide consent.
>
> Let's not return unsigned long -- DaveM's suggestion is far better.
> unsigned long is not opaque enough, IMHO.

I'm not sure to understand what's the proposed way to do offsetting:

#define IO_ADDR(cookie, ofs)?
(maybe with #define IO_SADDR(cookie, struct_name, field))
Others?

-- Abramo Bagnara mailto:abramo@alsa-project.org

Opera Unica Phone: +39.546.656023 Via Emilia Interna, 140 48014 Castel Bolognese (RA) - Italy

ALSA project http://www.alsa-project.org It sounds good! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Next message: Alexander Viro: "Re: Why recovering from broken configs is too hard"
Previous message: Pavel Machek: "Trivial cleanup in arch/i386/ptrace.c"
In reply to: Jeff Garzik: "Re: unsigned long ioremap()?"
Next in thread: David Woodhouse: "Re: unsigned long ioremap()?"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Thu May 03 2001 - 05:03:16 EDT