Re: [PATCH] 2.4.4-ac11 network drivers cleaning

From: Keith Owens (kaos@ocs.com.au)
Date: Sat May 19 2001 - 22:03:42 EDT

  • Next message: Matthew Wilcox: "Re: [RFD w/info-PATCH] device arguments from lookup, partion code"

    On Sat, 19 May 2001 17:58:49 -0400,
    Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
    >Finally, I don't know if I mentioned this earlier, but to be complete
    >and optimal, version strings should be a single variable 'version', such
    >that it can be passed directly to printk like
    >
    > printk(version);

    Nit pick. That has random side effects if version contains any '%'
    characters. Make it

            printk("%s\n", version);

    Not quite as optimal but safer.

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    This archive was generated by hypermail 2b29 : Sat May 19 2001 - 22:19:04 EDT