Re: [PATCH] 2.4.4-ac11 network drivers cleaning

From: Jeff Garzik (jgarzik@mandrakesoft.com)
Date: Sat May 19 2001 - 22:22:01 EDT

Next message: Richard Gooch: "Re: [RFD w/info-PATCH] device arguments from lookup, partion code"

Previous message: Ben Bridgwater: "Re: Brown-paper-bag bug in m68k, sparc, and sparc64 config files"
In reply to: Keith Owens: "Re: [PATCH] 2.4.4-ac11 network drivers cleaning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Keith Owens wrote:
>
> On Sat, 19 May 2001 17:58:49 -0400,
> Jeff Garzik <jgarzik@mandrakesoft.com> wrote:
> >Finally, I don't know if I mentioned this earlier, but to be complete
> >and optimal, version strings should be a single variable 'version', such
> >that it can be passed directly to printk like
> >
> > printk(version);
>
> Nit pick. That has random side effects if version contains any '%'
> characters. Make it
>
> printk("%s\n", version);
>
> Not quite as optimal but safer.

I disagree. Don't work around an escape bug in a version string, fix
it...

-- 
Jeff Garzik      | "Do you have to make light of everything?!"
Building 1024    | "I'm extremely serious about nailing your
MandrakeSoft     |  step-daughter, but other than that, yes."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Next message: Richard Gooch: "Re: [RFD w/info-PATCH] device arguments from lookup, partion code"
Previous message: Ben Bridgwater: "Re: Brown-paper-bag bug in m68k, sparc, and sparc64 config files"
In reply to: Keith Owens: "Re: [PATCH] 2.4.4-ac11 network drivers cleaning"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sat May 19 2001 - 22:26:33 EDT