> > Off-hand I see old style initialization. Is it right for new driver?
>
> the old-style init is because it is an old driver. I want to do a full-on
> rework, but haven't had the time.
New-style init by itself shouldn't be hard to do, independent of a full
re-work...
> > 2. Spaces and tabs are mixed in funny ways, makes to cute effects
> > when quoting diffs.
>
> I've tried to eliminate that when I see it - I'll give the diff a close
> examination.
Why not just run indent over the source before submitting. That will
regularize this stuff, and ensure that you are close to
Documentation/CodingStyle.
Here is the command I use. The first two options are the only really
importants ones...
indent -kr -i8 -npsl -pcs -l100 -lc120
(line length is 100 because line length 72/75/80 winds up wrapping long
printk and logic lines when typically the programmer didn't want them to
be wrapped)
-- Jeff Garzik | Disbelief, that's why you fail. Building 1024 | MandrakeSoft | - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Fri Jun 01 2001 - 03:31:47 EDT